Replace WeakMap with private fields #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `KeyringController` used a WeakMap to keep the keyring as a truly private field, such that code with a reference to the controller still could not access it. This strategy is no longer necessary as of TypeScript 4.3 because we now have support for true private fields. The TypeScript compiler will compile this to a similar WeakMap-based strategy. This should include no functional changes.
|
I will migrate the |
mcmire
approved these changes
Apr 20, 2022
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `KeyringController` used a WeakMap to keep the keyring as a truly private field, such that code with a reference to the controller still could not access it. This strategy is no longer necessary as of TypeScript 4.3 because we now have support for true private fields. The TypeScript compiler will compile this to a similar WeakMap-based strategy. This should include no functional changes.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `KeyringController` used a WeakMap to keep the keyring as a truly private field, such that code with a reference to the controller still could not access it. This strategy is no longer necessary as of TypeScript 4.3 because we now have support for true private fields. The TypeScript compiler will compile this to a similar WeakMap-based strategy. This should include no functional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
KeyringControllerused a WeakMap to keep the keyring as a truly private field, such that code with a reference to the controller still could not access it.This strategy is no longer necessary as of TypeScript 4.3 because we now have support for true private fields. The TypeScript compiler will compile this to a similar WeakMap-based strategy.
This should include no functional changes.