Reintroduce NotificationController for in-app notifications #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/notification-controller-v2
branch
from
77e70a1 to
dc1d9c9
Compare
2 tasks
FrederikBolding
force-pushed
the
fb/notification-controller-v2
branch
from
41a8799 to
825915d
Compare
FrederikBolding
changed the title
FrederikBolding
force-pushed
the
fb/notification-controller-v2
branch
from
b81d4fe to
fb3c033
Compare
Gudahtt
reviewed
Apr 14, 2022
Gudahtt
reviewed
Apr 14, 2022
Gudahtt
reviewed
Apr 14, 2022
Gudahtt
reviewed
Apr 14, 2022
Gudahtt
reviewed
Apr 14, 2022
Gudahtt
reviewed
Apr 14, 2022
mcmire
reviewed
Apr 15, 2022
FrederikBolding
force-pushed
the
fb/notification-controller-v2
branch
from
0575421 to
852973b
Compare
mcmire
previously approved these changes
Apr 19, 2022
Gudahtt
requested changes
Apr 21, 2022
There was a problem hiding this comment.
The restricted messenger type in the tests should be corrected, and I'd at least like to hear a reason for the native notifications being included (this thread)
Fixed the type. I thought it would be nice to use the same API for in-app and native notifications, but I see your points in the thread as well. I have removed it for now. |
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Revive NotificationControllerV2 for in-app notifications * Add more functionality and tests * Test another case * Remove getCurrent, add getNotifications * Add a bit more information to the notifications * Add getUnreadCount * Rename to NotificationController * Support multiple ids for dismissing and marking as read * Simplify further * Run linting * Fix some PR comments * Remove getters * Add readDate * Add some documentation * Expand test slightly * Fix test type * Remove native notifications
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Revive NotificationControllerV2 for in-app notifications * Add more functionality and tests * Test another case * Remove getCurrent, add getNotifications * Add a bit more information to the notifications * Add getUnreadCount * Rename to NotificationController * Support multiple ids for dismissing and marking as read * Simplify further * Run linting * Fix some PR comments * Remove getters * Add readDate * Add some documentation * Expand test slightly * Fix test type * Remove native notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reintroduces the
NotificationControllerfor in-app notifications.NotificationControllerfor in-app notifications.Checklist
Issue
Progresses MetaMask/metamask-extension#13553