Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in transect operator #731

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Fix bug in transect operator #731

merged 2 commits into from
Jul 5, 2024

Conversation

jwarner8
Copy link
Contributor

@jwarner8 jwarner8 commented Jul 4, 2024

Fixes a bug in the transect operator where the minimum grid spacing could become negative.
Fixes a bug in the meta-data where too many triggers are used (thanks @daflack for spotting this).
Fixes missing entries in the rose-suite.conf.example file for the transect.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jwarner8 jwarner8 self-assigned this Jul 4, 2024
@jwarner8 jwarner8 added the bug Something isn't working label Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Coverage

@jwarner8 jwarner8 requested a review from jfrost-mo July 4, 2024 16:06
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jfrost-mo
Copy link
Member

Go ahead and merge.

@jwarner8 jwarner8 merged commit 75a93fe into main Jul 5, 2024
7 checks passed
@jwarner8 jwarner8 deleted the transect_fixes branch July 5, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants