Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend UM vertical plotting to model level #697

Merged

Conversation

Sylviabohnenstengel
Copy link
Contributor

@Sylviabohnenstengel Sylviabohnenstengel commented Jun 26, 2024

Fixes #658
Um based vertical plotting on model levels
UM based spatial contour plots on model levels

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Added an entry to the top of docs/source/changelog.rst
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@Sylviabohnenstengel
Copy link
Contributor Author

ensure to review #638 first

@Sylviabohnenstengel Sylviabohnenstengel marked this pull request as ready for review June 26, 2024 13:24
Copy link
Contributor

github-actions bot commented Jun 26, 2024

Coverage

@Sylviabohnenstengel
Copy link
Contributor Author

coverage report failing. This should be solved by addressing the coverage report issue in PR #638

@Sylviabohnenstengel
Copy link
Contributor Author

ensure to review #638 first

@jfrost-mo jfrost-mo changed the base branch from main to 637_lfric_extension_to_vertical_profile June 27, 2024 08:52
@jfrost-mo jfrost-mo changed the title 658 extend um vertical plotting to modellevel Extend UM vertical plotting to model level Jun 27, 2024
@jfrost-mo jfrost-mo force-pushed the 637_lfric_extension_to_vertical_profile branch 2 times, most recently from 43bf53f to 9ad955d Compare June 27, 2024 15:59
@jfrost-mo jfrost-mo added the enhancement New feature or request label Jun 28, 2024
@jfrost-mo jfrost-mo force-pushed the 637_lfric_extension_to_vertical_profile branch from 477c4ca to 10f69ee Compare July 1, 2024 10:32
Base automatically changed from 637_lfric_extension_to_vertical_profile to main July 1, 2024 14:18
@jfrost-mo jfrost-mo force-pushed the 658_extend_um_vertical_plotting_to_modellevel branch from a87b854 to d0455d0 Compare July 1, 2024 14:56
@jfrost-mo jfrost-mo force-pushed the 658_extend_um_vertical_plotting_to_modellevel branch from 978687a to 081a001 Compare July 1, 2024 15:00
@jfrost-mo
Copy link
Member

Branch rebased.

@Sylviabohnenstengel
Copy link
Contributor Author

corrected recipe to reflect new vertical level constraint

Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor help text comments, but otherwise happy to approve, and then ready to merge.

cset-workflow/meta/rose-meta.conf Outdated Show resolved Hide resolved
cset-workflow/meta/rose-meta.conf Outdated Show resolved Hide resolved
@jfrost-mo jfrost-mo force-pushed the 658_extend_um_vertical_plotting_to_modellevel branch from 698ab0a to 118daf4 Compare July 4, 2024 13:43
Sylviabohnenstengel and others added 3 commits July 4, 2024 14:47
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
…el_series.yaml

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
@Sylviabohnenstengel Sylviabohnenstengel merged commit d57c88b into main Jul 4, 2024
7 checks passed
@Sylviabohnenstengel Sylviabohnenstengel deleted the 658_extend_um_vertical_plotting_to_modellevel branch July 4, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend vertical line plot to plotting against model_level and height
2 participants