Refactoring keyboard handling #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SD10
commented
Sep 14, 2017
Sources/MessagesViewController.swift
Outdated
| messagesCollectionView.topAnchor.constraint(equalTo: view.topAnchor), | ||
| messagesCollectionView.leadingAnchor.constraint(equalTo: view.leadingAnchor), | ||
| messagesCollectionView.trailingAnchor.constraint(equalTo: view.trailingAnchor), | ||
| let top = messagesCollectionView.topAnchor.constraint(equalTo: topLayoutGuide.bottomAnchor) |
There was a problem hiding this comment.
This may have to be changed to constraint(equalTo: view.topAnchor, constant: topLayoutGuide.length)
Codecov Report
@@ Coverage Diff @@
## v0.8.0 #125 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 77 77
=====================================
Hits 77 77Continue to review full report at Codecov.
|
SD10
changed the title
SD10
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
contentInsetof the collection view. This was blocking can i add view on top of MessagesViewController like header view #117