Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add hyperlink icon to (full_reference_link) nodes #75

Closed
ValdezFOmar opened this issue Jul 19, 2024 · 2 comments
Closed

feature: Add hyperlink icon to (full_reference_link) nodes #75

ValdezFOmar opened this issue Jul 19, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ValdezFOmar
Copy link

Is your feature request related to a problem? Please describe.

Reference links don't get an icon when rendered. With the following markdown file:

1. This is some [link](https://example.com) 
2. This is some [link][example-link] 

[example-link]: https://example.com

Only the first example gets an icon but not the second.

image

Describe the solution you'd like

Add the same icon use for (inline_link) nodes.

Describe alternatives you've considered

None

Additional information

Tree-sitter tree:

(document ; [0, 0] - [4, 0]
  (section ; [0, 0] - [4, 0]
    (list ; [0, 0] - [3, 0]
      (list_item ; [0, 0] - [1, 0]
        (list_marker_dot) ; [0, 0] - [0, 3]
        (paragraph ; [0, 3] - [1, 0]
          (inline ; [0, 3] - [0, 43]
            (inline ; [0, 3] - [0, 43]
              (inline_link ; [0, 16] - [0, 43]
                (link_text) ; [0, 17] - [0, 21]
                (link_destination)))))) ; [0, 23] - [0, 42]
      (list_item ; [1, 0] - [3, 0]
        (list_marker_dot) ; [1, 0] - [1, 3]
        (paragraph ; [1, 3] - [2, 0]
          (inline ; [1, 3] - [1, 36]
            (inline ; [1, 3] - [1, 36]
              (full_reference_link ; [1, 16] - [1, 36]
                (link_text) ; [1, 17] - [1, 21]
                (link_label)))) ; [1, 22] - [1, 36]
          (block_continuation)))) ; [2, 0] - [2, 0]
    (link_reference_definition ; [3, 0] - [4, 0]
      (link_label) ; [3, 0] - [3, 14]
      (link_destination)))) ; [3, 16] - [3, 35]
@ValdezFOmar ValdezFOmar added the enhancement New feature or request label Jul 19, 2024
MeanderingProgrammer added a commit that referenced this issue Jul 23, 2024
@MeanderingProgrammer
feature: Add support for full_reference_link nodes
5879827 
## Details

Requested: #75

Adds hyperlink icon in front of full_reference_link nodes.
@MeanderingProgrammer
Copy link
Owner

Added here: 5879827

Please update and lmk if it works!

@ValdezFOmar
Copy link
Author

Thanks, it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MeanderingProgrammer @ValdezFOmar