Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with ordered lists and config defaults #7

Closed
bertradio opened this issue Mar 22, 2024 · 3 comments
Closed

Problems with ordered lists and config defaults #7

bertradio opened this issue Mar 22, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@bertradio
Copy link

bertradio commented Mar 22, 2024 •
edited
Loading

I really love the approach of this plugin.

But it seems to have a problem with display of ordered lists. Unless they are indented a couple of times they don't display with the numbers, only the icons and a "."

So I tried using the full setup config from the help file. That completely crashed the plugin and I had to remove it. Is there an updated version?

Thanks for the great work!
@bertradio bertradio changed the title Problems with ordered lists and conig defauots Problems with ordered lists and config defaults Mar 22, 2024
@MeanderingProgrammer
Copy link
Owner

Thanks for bringing these problems up!

For the latter problem of the config this was due to me using vim.tbl_deep_extend when combining the default config and the user config, which ended up removing the metatable of the query object when a user config is provided.

I updated the configuration to accept a string instead and to do the parsing of the query in the plugin itself: 70f8f4f.

So now providing the full configuration as in the README should work.

I hadn't thought of ordered lists, haha, you're right, this does not work for them. Still working on fixing this problem.

@MeanderingProgrammer MeanderingProgrammer added the bug Something isn't working label Mar 23, 2024
@MeanderingProgrammer
Copy link
Owner

Ordered lists should no longer use the bullet point after this change: f5917d2

Thanks for reaching out and feel free to re-open if there is still a problem!

@bertradio
Copy link
Author

bertradio commented Mar 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bertradio @MeanderingProgrammer