Add kgen utility to dump random data into Kafka
#3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesch
approved these changes
Jul 28, 2020
quodlibetor
approved these changes
Jul 28, 2020
src/kafka-util/src/bin/kgen.rs
Outdated
Comment on lines
13
to
18
| use rdkafka::{ | ||
| error::KafkaError, | ||
| producer::{BaseRecord, DefaultProducerContext, ThreadedProducer}, | ||
| types::RDKafkaError, | ||
| ClientConfig, | ||
| }; |
There was a problem hiding this comment.
we don't enforce this (because it's impossible to) so TIOLI, but we do normally ensure that use lines have the crate at the beginning of all imports.
Considering the state of rust tooling overall I like being able to rg rdkafka.*Client and have that be guaranteed to find all modules that use rdkafka::ClientConfig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is