Allow constrained type parameters in variant #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still doens't work though: julia> using SumTypes
julia> @sum_type QP{X<:Real, Y<:Real} begin
Q{X<:AbstractFloat}(a::X)
P{Y<:Integer}(b::Y)
end
ERROR: TypeError: in QP, in Y, expected Y<:Real, got Type{Uninit}
Stacktrace:
[1] top-level scope
@ ~/.julia/dev/SumTypes/src/sum_type.jl:203while this does: julia> using SumTypes
julia> @sum_type QP{X<:Union{Real, SumTypes.Uninit}, Y<:Union{Real, SumTypes.Uninit}} begin
Q{X<:AbstractFloat}(a::X)
P{Y<:Integer}(b::Y)
endbut it shouldn't be necessary to have this merged, we can patch the first version in a separate PR |
|
ok I made it work here julia> using SumTypes
julia> @sum_type QP{X<:Real, Y<:Real} begin # now this works
Q{X<:AbstractFloat}(a::X)
P{Y<:Integer}(b::Y)
end |
|
I'm still a little skeptical about whether this is a good idea, but I guess I also don't see the harm in it, so let's merge it. Thank you for implementing this @Tortar! |
|
thanks for merging it in so quickly, could you please release a new version? I'd like to use this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73