Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to document sum types #63

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

Tortar
Copy link
Contributor

@Tortar Tortar commented Jan 20, 2024

Fixes #32

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f5b1cf) 100.00% compared to head (21e3958) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          264       265    +1     
=========================================
+ Hits           264       265    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tortar
Copy link
Contributor Author

Tortar commented Jan 20, 2024

Fails on nightly, but I guess this is a Julia bug

@MasonProtter
Copy link
Owner

Oh I didn't realize it was so simple to support docstrings!

@MasonProtter
Copy link
Owner

Interesting that this doesn't work on Master, would you mind filing an issue in the upstream julia repo?

@MasonProtter MasonProtter merged commit 1739ac3 into MasonProtter:master Jan 20, 2024
7 of 8 checks passed
@Tortar
Copy link
Contributor Author

Tortar commented Jan 20, 2024

yeah, I tried to reduce it but with no avail.

I will point to the ci in this pr then :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc Comments with @sum_type
2 participants