Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow abstract type for sum type #61

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Conversation

Tortar
Copy link
Contributor

@Tortar Tortar commented Jan 20, 2024

Fixes #44

Hi @MasonProtter, I'd like to allow defining abstract types in my interface package (StructSumTypes.jl) to your (very cool) package.

I hope I didn't overlook anything

@Tortar Tortar changed the title Implement abstract type for sum type Allow abstract type for sum type Jan 20, 2024
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4edded4) 100.00% compared to head (0082573) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          261       264    +3     
=========================================
+ Hits           261       264    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MasonProtter
Copy link
Owner

Very cool, thank you @Tortar. This should also close #44

@MasonProtter MasonProtter merged commit cc40924 into MasonProtter:master Jan 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying a supertype
2 participants