Back to union storage #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 4 3 -1
Lines 360 249 -111
==========================================
- Hits 360 249 -111
|
|
@Krastanov, I know you have some code relying on SumTypes.jl for performance referenced in #28. Could I ask you to test out this PR and see if it causes any performance regressions (or improvements!) for you? |
|
Yes, I should be able to do so today or tomorrow. |
|
The only interesting benchmarks I have are with
Tested on: If you want to double check things for yourself, these are the benchmarks that depend on sumtypes: |
|
Well that’s quite encouraging news! I guess julia’s handling of enclosed unions here is a bit smarter than what I was doing and enabled some speedups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undoes the major overhaul of version 0.4 where we were doing computed storage. With this change, a bunch of things get a lot simpler, and we don't need to carry around extra parameters in the sum type.
While the computed storage did benefit some situations, julia's
Unionis also quite good. For allisbitsdata it should have the same performance profile as before, but for non-isbitsdata, there are some tradeoffs as to what ends up heap allocated and what doesn't, and I think thatUnionactually does a better job when you're modifying and interacting with the data since there's usually fewer pointers involved.Fixes #30