ETR - File Browser Update #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions in the FileViewer are attempting to iterate over the file and image extensions that the user defines in the settings.ini.cfm as filebrowsereditlist etc. However, the iteration is happening over a string.
add same change to isViewable
|
|
Updates the actionwindow wrapper and formwrapper to fix the Edit modal when editing files in the filebrowser.
| @@ -144,15 +144,15 @@ | |||
|
|
|||
| #actionwindow-wrapper { | |||
| position: absolute; | |||
| margin: 60px 30%; | |||
| margin: 30px 30px; | |||
There was a problem hiding this comment.
I would revert this change; the old css makes sure that the popup is always centered in the middle.
There was a problem hiding this comment.
@jeroenweareorangeeu Reverted, cheers.
revert margin in the actionwindow-wrapper
guustnieuwenhuis
approved these changes
Jun 21, 2024
|
Thank you @wtconsulting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions in the FileBrowser / FileViewer are attempting to iterate over the file and image extensions that the user defines in the settings.ini.cfm as filebrowsereditlist etc. However, the iteration is happening over a string.
This image illustrates the issue. Note the "t" in the debug popup where it should be comparing against a whole extension (txt for example).
I also updated the CSS to fix the Edit window being cut in half and right justified on the page.
Note I made this change in a non-minified JS file. If you need me to minify it or make any updates, I can do that as well. I did test that this resolves the issues.