Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use api/src/ in Dockerfile #891

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Use api/src/ in Dockerfile #891

merged 2 commits into from
Jan 13, 2021

Conversation

wslulciuc
Copy link
Member

This PR fixes the docker build by using the path api/src/ in Dockerfile.

@wslulciuc
Use api/src/ in Dockerfile
097ae65 
Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc wslulciuc added the review Ready for review label Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021 •
edited
Loading

Codecov Report

Merging #891 (23908f0) into main (bf45f28) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #891   +/-   ##
=========================================
  Coverage     74.30%   74.30%           
  Complexity      500      500           
=========================================
  Files           117      117           
  Lines          2370     2370           
  Branches        234      234           
=========================================
  Hits           1761     1761           
  Misses          304      304           
  Partials        305      305

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf45f28...23908f0. Read the comment docs.

henneberger
henneberger approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@henneberger henneberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be better to move to the api folder

@wslulciuc wslulciuc removed the review Ready for review label Jan 13, 2021
@wslulciuc
Copy link
Member Author

may be better to move to the api folder

@henneberger: I agree, but we'll also have to move the gradle files to api/src as well to properly build the docker image with docker compose. It's something we can look into as follow up work.

@wslulciuc wslulciuc merged commit ab3e424 into main Jan 13, 2021
@wslulciuc wslulciuc deleted the bug/path-to-src-in-dockerfile branch January 13, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henneberger henneberger henneberger approved these changes

@julienledem julienledem julienledem approved these changes

@phixMe phixMe Awaiting requested review from phixMe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wslulciuc @julienledem @henneberger