Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes centered on Creality Ender-3 Pro with v4.2.2 control board #877

Merged
merged 3 commits into from
Feb 12, 2023

Conversation

McNeight
Copy link
Contributor

@McNeight McNeight commented Jan 4, 2023

Description

  • Incorporated changes required to work with my printer, as well as auto-tune PID values.
  • Synced some changes from CrealityV427/Configuration.h as well as config/default/Configuration.h as made sense.
  • Synced some changes from CrealityV427/Configuration_adv.h as well as config/default/Configuration_adv.h as made sense.
  • Added more details to CUSTOM_MACHINE_NAME in CrealityV427/Configuration.h to make easier distinction between v4.2.2 and v4.2.7.
  • Created new configuration file for use with official Creality BLTouch probe.
    • Contains correct #defines set as well as probe offset from stock hot end.

Benefits

Improves compatibility with Creality Ender-3 Pro with a v4.2.2 control board.

Related Issues

Unknown.

+ Incorporated changes required to work with my printer, as well as auto-tune PID values.
+ Synced some changes from CrealityV427/Configuration.h as well as config/default/Configuration.h as made sense.
+ Synced some changes from CrealityV427/Configuration_adv.h as well as config/default/Configuration_adv.h as made sense.
+ Added more details to CUSTOM_MACHINE_NAME in CrealityV427/Configuration.h to make easier distinction between v4.2.2 and v4.2.7.
+ Created new configuration file for use with official Creality BLTouch probe.
  + Contains correct #defines set as well as probe offset from stock hot end.
@cbagwell
Copy link

cbagwell commented Jan 4, 2023

I compared the various Ender 3 Pro config files as well and settled on similar set of changes so it would be nice to get a version of this pushed to save others some time. I'll add a few comments where I came up with differences.

@@ -113,8 +113,7 @@
*
* :[2400, 9600, 19200, 38400, 57600, 115200, 250000, 500000, 1000000]
*/
#define BAUDRATE 115200

#define BAUDRATE 250000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the configs have 115200 and this assumption is baked in to lots of external apps so I'd leave it at current value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I'll change it back.


/**
* Prevent a single extrusion longer than EXTRUDE_MAXLENGTH.
* Note: For Bowden Extruders make this large enough to allow load/unload.
*/
#define PREVENT_LENGTHY_EXTRUDE
#define EXTRUDE_MAXLENGTH 1000
#define EXTRUDE_MAXLENGTH 200
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use something like Octoprint to help automate filament load/unload or use Marlins built in version then this value needs to be at least 600. So in this case, I think its V427 config that needs update and not V422.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make a change to both config files, set it to 600, and maybe include a comment specifying why the value is what it is?

@@ -1171,7 +1170,7 @@
* Override with M92
* X, Y, Z [, I [, J [, K...]]], E0 [, E1[, E2...]]
*/
#define DEFAULT_AXIS_STEPS_PER_UNIT { 80, 80, 400, 93 }
#define DEFAULT_AXIS_STEPS_PER_UNIT { 80, 80, 400, 111.2 }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

93 is the correct value for the stock extruder with no bowden tube connected. I'd leave at existing value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 111.2 was the value measured on my printer, but I can set it back to 93.

@thinkyhead thinkyhead merged commit 5896cbd into MarlinFirmware:import-2.1.x Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants