Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tevo Tornado needs ENDSTOP_NOISE_THRESHOLD #833

Merged
merged 2 commits into from
Oct 22, 2022

Conversation

shorage
Copy link
Contributor

@shorage shorage commented Oct 21, 2022

line 1142 uncomment, it is NEEDED
#define ENDSTOP_NOISE_THRESHOLD 2 //Needed for stock Tevo Tornado

Description

line 1142 uncomment, it is NEEDED
#define ENDSTOP_NOISE_THRESHOLD 2 //Needed for stock Tevo Tornado
Requirements

Benefits

I can home without printer fault

Related Issues

Speradic printer faults during auto home

#define ENDSTOP_NOISE_THRESHOLD 2 // Must be enabled for stock Tornado
@thisiskeithb
Copy link
Member

The V1 / MKS Base variant should be updated as well since ENDSTOP_NOISE_THRESHOLD is disabled:

@shorage shorage changed the title Update Configuration.h Update Configuration.h - line 1142 should be uncommented, #define ENDSTOP_NOISE_THRESHOLD 2 //Needed for stock Tevo Tornado Oct 21, 2022
@thinkyhead thinkyhead changed the title Update Configuration.h - line 1142 should be uncommented, #define ENDSTOP_NOISE_THRESHOLD 2 //Needed for stock Tevo Tornado Tevo Tornado needs ENDSTOP_NOISE_THRESHOLD Oct 22, 2022
@thinkyhead
Copy link
Member

The V1 / MKS Base variant should be updated as well since ENDSTOP_NOISE_THRESHOLD is disabled…

Most important if it's an endstop issue and not a board issue, but it never hurts to enable this on any machine.

@thisiskeithb
Copy link
Member

Most important if it's an endstop issue and not a board issue,

I never ran into it on my original Tornado with an MKS Base or when I upgraded it to a Gen-L, but like you said, it doesn't hurt to enable it.

@thinkyhead thinkyhead merged commit 798adc7 into MarlinFirmware:import-2.1.x Oct 22, 2022
@shorage
Copy link
Contributor Author

shorage commented Oct 22, 2022

Most important if it's an endstop issue and not a board issue,

I never ran into it on my original Tornado with an MKS Base or when I upgraded it to a Gen-L, but like you said, it doesn't hurt to enable it.

Fair enough, i did test my endstops and they checked good. It prints like a beast with this enabled. Without it i cant get passed homing. Took me 2 days and reviewed the config hundreds of times before i enabled it. If it saves someone some time, i think it is worth it. It would randomly choose to fault without it enabled during the homing process or x-y movement and it would never be in a consistent spot. Tested a bunch of end-stops i had laying around. I have Marlin 1.1.9 for the longest and i noticed this was enabled. Then tried it. Now all is well.

Regards,

Frank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants