Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PolyominoIdeals—a package to deal with polyomino ideals #2716

Merged
merged 6 commits into from
Dec 24, 2022
Merged

PolyominoIdeals—a package to deal with polyomino ideals #2716

merged 6 commits into from
Dec 24, 2022

Conversation

dr-rizwanj
Copy link
Contributor

We provide a package to deal with ideals related to the collection of cells and polyominoes, as defined by Qureshi in "Ideals generated by 2-minors, collections of cells and stack polyominoes, Journal of Algebra, Vol. 357, No. 3, pp. 279 – 303, July 2012. DOI: 10.1016/j.jalgebra.2012.01.032".

The package consists of the three functions polyoIdeal, polyoToric and polyoMatrix and related options explained in the documentation.

@dr-rizwanj dr-rizwanj marked this pull request as ready for review December 22, 2022 11:53
@dr-rizwanj dr-rizwanj changed the title PlyominoIdeals—a package to deal with polyomino ideals PolyominoIdeals—a package to deal with polyomino ideals Dec 22, 2022
@DanGrayson DanGrayson changed the base branch from master to development December 24, 2022 17:03
@DanGrayson DanGrayson merged commit cdf2e3c into Macaulay2:development Dec 24, 2022
@DanGrayson
Copy link
Member

Here are some misspelled words that need fixing:

M2/Macaulay2/packages/PolyominoIdeals.m2:108: intervall ==> interval
M2/Macaulay2/packages/PolyominoIdeals.m2:[11](https://github.com/Macaulay2/M2/actions/runs/3773176498/jobs/6414497709#step:5:12)3: enconding ==> encoding
M2/Macaulay2/packages/PolyominoIdeals.m2:417: varibles ==> variables
M2/Macaulay2/packages/PolyominoIdeals.m2:439: Combinatorical ==> Combinatorial
M2/Macaulay2/packages/PolyominoIdeals.m2:501: intervall ==> interval
M2/Macaulay2/packages/PolyominoIdeals.m2:601: intervall ==> interval
M2/Macaulay2/packages/PolyominoIdeals.m2:641: tha ==> than, that, the
M2/Macaulay2/packages/PolyominoIdeals.m2:641: intervall ==> interval

@dr-rizwanj
Copy link
Contributor Author

The words are fixed and submitted as a new pull request.

@DanGrayson
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dr-rizwanj @DanGrayson