Skip to content
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.

Use a minimal Windows docker container to check the wheels #44

Closed
scikit-learn/scikit-learn
#18802
@ogrisel

Description

Such a minimal windows test environment should have no C/C++ compiler installed, nor SDK, nor redistributable runtime such as c:\Windows\System32\vcomp140.dll nor even Miniconda. Indeed Miniconda ships its own bunch of system dlls such as vcomp140.dll by default.

The goal would be to detect problems such as scikit-learn/scikit-learn#15899 before releasing.

Instead it should install Python from https://www.python.org (e.g. an embedded zip or from the .msi installer which can be installed from the command line).

We should probably do that based on #23 as the current AppVeyor worker is really too slow to iterate with.

A minimal test environment is probably achievable using a Windows servercore container although I have never tried myself.

References

Powershell script to download install python .msi from python.org:
https://github.com/ogrisel/python-appveyor-demo/blob/master/appveyor/install.ps1#L104

Windows containers on Azure Pipelines:
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/container-phases?view=azure-devops&tabs=yaml#windows-containers

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions