Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVED] Combined cleanup tasks into single PHP #1764

Merged
merged 1 commit into from
Feb 16, 2014
Merged

Conversation

TheSerapher
Copy link
Contributor

  • [IMPROVED] Logging format for all cleanup tasks
  • [UPDATED] Cron shellescripts
  • [UPDATE] Cron Monitoring Page
  • [DELETED] Old *_cleanup.php scripts

* [IMPROVED] Logging format for all cleanup tasks
* [UPDATED] Cron shellescripts
* [UPDATE] Cron Monitoring Page
* [DELETED] Old `*_cleanup.php` scripts
@TheSerapher
Copy link
Contributor Author

This will improved our cleanup loggings a fair bit and will now include runtime information for each task - similar to the log-formatting branch in tickerupdate.php cronjob, each cleanup tasks generates a table entry.

Needs a bit of testing since I moved crons around.

@TheSerapher
Copy link
Contributor Author

@iAmShorty Maybe you can find someone (or yourself) to do a few quick tests? I forgot some things last time I added a new cron, so I'd like to get it checked before I merge it.

@iAmShorty
Copy link
Contributor

will add it and check this when i'm at home

@iAmShorty
Copy link
Contributor

works, but disabled is not showing under monitoring in admin settings. there's no entry in table monitoring with tables_cleanup_disabled, but for other crons there is. maybe that's why my crons halted some time ago and the entry is only created when cron stops?

bildschirmfoto 2014-02-16 um 00 01 20

Found:

    if ($fatal) {
      if ($exitCode != 0) $this->setStatus($cron_name . "_disabled", "yesno", 1);
      exit($exitCode);
    }

so it's only shown if crons stops the first time and then it's shown every time. is this normal behavior?

@TheSerapher
Copy link
Contributor Author

Yes that's normal. Disabled only shows if the cron was disabled at least once.

@iAmShorty
Copy link
Contributor

ok, then it runs without errors :)

TheSerapher added a commit that referenced this pull request Feb 16, 2014
[IMPROVED] Combined cleanup tasks into single PHP
@TheSerapher TheSerapher merged commit 5c22cc3 into next Feb 16, 2014
@TheSerapher TheSerapher deleted the combine-cleanups branch February 16, 2014 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants