-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example(gwe-barends): "thermal bleeding" (conduction) example based on Barends solution #228
Conversation
emorway-usgs
commented
Sep 10, 2024
- Attempted local spell check using Word
- Ran ruff on python file
- Updated body.tex by referring it to the new .tex file description of the Barends problem
@langevin-usgs, From about 148 seconds to 36 seconds. The model only takes about 13 seconds on my local machine, then calculation of the analytical solution, and finally the matplotlib figure generation takes the rest of the time. After coarsening the grid, fits still seem reasonable, but are eroding. Added note to the base script about restoring more fine discretization for improving the analytical-gwe comparison. |
…al solution (and therefore removed the analytical solution entirely)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @emorway-usgs, I like this simplified version of Barends. I pulled down the rtd artifacts and looked at the notebook. It shows that this model takes 50 seconds to run. Can we get something that looks okay with much fewer cells? Like maybe 50 columns by 25 layers? Would be nice to get this runtime to less than 5 seconds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, great. Looks good to me.