Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example(gwe-barends): "thermal bleeding" (conduction) example based on Barends solution #228

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

emorway-usgs
Copy link
Contributor

  • Attempted local spell check using Word
  • Ran ruff on python file
  • Updated body.tex by referring it to the new .tex file description of the Barends problem

@emorway-usgs
Copy link
Contributor Author

@langevin-usgs, From about 148 seconds to 36 seconds. The model only takes about 13 seconds on my local machine, then calculation of the analytical solution, and finally the matplotlib figure generation takes the rest of the time. After coarsening the grid, fits still seem reasonable, but are eroding. Added note to the base script about restoring more fine discretization for improving the analytical-gwe comparison.

@emorway-usgs emorway-usgs changed the title example(gwe-barends): thermal bleeding examples based on Barends solution example(gwe-barends): "thermal bleeding" (conduction) example based on Barends solution Sep 19, 2024
…al solution (and therefore removed the analytical solution entirely)
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @emorway-usgs, I like this simplified version of Barends. I pulled down the rtd artifacts and looked at the notebook. It shows that this model takes 50 seconds to run. Can we get something that looks okay with much fewer cells? Like maybe 50 columns by 25 layers? Would be nice to get this runtime to less than 5 seconds.

@emorway-usgs
Copy link
Contributor Author

Opted for a slightly different direction and coarsened the temporal resolution to keep the image from getting grainy. Clocked it at 3 seconds:

3_secs

Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, great. Looks good to me.

@langevin-usgs langevin-usgs merged commit c5b10d3 into MODFLOW-USGS:develop Sep 27, 2024
10 checks passed
@emorway-usgs emorway-usgs deleted the barends branch September 27, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants