Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(idm): reset auxvar 2d arrray in array input loader each period #1548

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented Jan 10, 2024

The Modflow6 input/output guide describes the input aux parameter for EVT and RCH Array-Based Input, which includes the line:

If an array is not specified for an auxiliary variable, then a value of zero is assigned.

When the input specifies a TAS for the aux parameter it is already reset because the TAS manager is reset. However, the parameter is not currently explicitly reset to zero when not associated with a TAS.

Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix seems worthy of a a bullet in the release notes as it may affect existing models and behavior.

end if
end do
!
! -- explicitly reset auxvar array each period
this%bndctx%auxvar = DZERO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably loop through each array element and set to zero, rather than using a single expression. Maybe it doesn't matter with latest compilers, but these types of assignments have given us stack issues in the past.

@langevin-usgs langevin-usgs added this to the 6.4.3 milestone Jan 11, 2024
@mjreno
Copy link
Contributor Author

mjreno commented Jan 11, 2024

@langevin-usgs This fixes an issue in the develop branch but it has not been exposed through an official release- should release notes still be updated?

@langevin-usgs
Copy link
Contributor

@langevin-usgs This fixes an issue in the develop branch but it has not been exposed through an official release- should release notes still be updated?

Yes, we should be updating the release notes as the changes get merged into develop. The release notes should document changes in develop that will affect users. In the release notes folder, there is a develop.tex file where descriptions can go.

@langevin-usgs langevin-usgs merged commit 657b2b9 into MODFLOW-USGS:develop Jan 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants