feat(par): add mover functionality to parallel capabilities #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- split mover in provider,receiver parts
…into par-exg-mvr
- ncpus can now be set per simulation in testframework
langevin-usgs
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Hey @mjr-deltares, this looks really nice, especially considering how difficult it seemed back when we first started talking about it. I see you've added the parallel test of the xmvr. Should we think about adding another test in the future for the bidirectional flow case?
|
Hi @langevin-usgs , good point! Let's try and put it in with this PR. I will set up something, might contact you offline. |
- fix printing of MVR table with qavailable in parallel
|
@langevin-usgs : I have included that test we talked about. Also sync'ed qavailable such that the MVR flow rates printed to the list file are correct. |
langevin-usgs
approved these changes
Jan 22, 2024
This was referenced Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.