Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SOA-027][Enhancement] Re-structure the code to handle the Delete Conditions. #47

Closed
LyQuocCuong opened this issue Jul 22, 2023 · 4 comments · Fixed by #55
Closed

[SOA-027][Enhancement] Re-structure the code to handle the Delete Conditions. #47

LyQuocCuong opened this issue Jul 22, 2023 · 4 comments · Fixed by #55
Assignees
@LyQuocCuong
Labels
[Level] - Hard Level of Issues [Note] Lesson Lessons (code, bug, mistakes,..) [Note] Overtime When the issues need more time to solve than the estimation [Type] Enhancement Type of Issues
Milestone
[Stage01] Foundat...

Comments

@LyQuocCuong
Copy link
Owner

=====BEFORE=====

1) Describe the current situation

  • Currently, I am using Delete Condition Enums for each Entity. It's difficult to summarize the number of conditions for writing LogMessages.

2) What are the ideas for it?

  • I will collect all conditions into one place (ConditionsForDeletingEntityCollection). Each Entity will be assigned the needed condition from it.

3) Is it mandatory/optional? What if I don't enhance?

  • It's mandatory for managing conditions and writing LogMessages.

=====AFTER=====

1) Describe the solutions

2) Pros and Cons of this solution

3) Are there any NEW (technical, code,...) ?

4) Is it challenging and difficult to do? Why?

5) Any other notes?
@LyQuocCuong LyQuocCuong added [Type] Enhancement Type of Issues [Level] Easy Level of Issues [Note] Lesson Lessons (code, bug, mistakes,..) labels Jul 22, 2023
@LyQuocCuong LyQuocCuong added this to the [S01] Foundation (Basic) milestone Jul 22, 2023
@LyQuocCuong LyQuocCuong self-assigned this Jul 22, 2023
@github-project-automation github-project-automation bot moved this to ⚫ Not Started in eShopOnlineApi Jul 22, 2023
@LyQuocCuong LyQuocCuong moved this from ⚫ Not Started to 🔖 Ready in eShopOnlineApi Jul 22, 2023
@LyQuocCuong LyQuocCuong moved this from 🔖 Ready to 🏗 In progress in eShopOnlineApi Jul 23, 2023
@LyQuocCuong LyQuocCuong added [Level] - Hard Level of Issues and removed [Level] Easy Level of Issues labels Jul 25, 2023
@LyQuocCuong LyQuocCuong changed the title [SOA-027][Enhancement] Collect all the delete conditions into one place. [SOA-027][Enhancement] Re-structure the code to handle the Delete Conditions. Jul 25, 2023
@LyQuocCuong
Copy link
Owner Author

image

@LyQuocCuong
Copy link
Owner Author

image

@LyQuocCuong
Copy link
Owner Author

image

@LyQuocCuong LyQuocCuong linked a pull request Jul 25, 2023 that will close this issue
[SOA-027][Enhancement] Re-structure the code to handle the Delete Conditions. #55
Merged
@LyQuocCuong LyQuocCuong moved this from 🏗 In progress to ✅ Done in eShopOnlineApi Jul 25, 2023
@LyQuocCuong
Copy link
Owner Author

=====AFTER=====

1) Describe the solutions

  • Commented by images.

2) Pros and Cons of this solution

  • Pros: can extend for many kinds of Conditions (Update, Create,..).
  • Cons: It may be difficult to understand at first.

3) Are there any NEW (technical, code,...) ?

  • No.

4) Is it challenging and difficult to do? Why?

  • It's Challenging. It takes time to think of the solutions.

5) Any other notes?

  • No.

@LyQuocCuong LyQuocCuong added the [Note] Overtime When the issues need more time to solve than the estimation label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LyQuocCuong LyQuocCuong

Labels
[Level] - Hard Level of Issues [Note] Lesson Lessons (code, bug, mistakes,..) [Note] Overtime When the issues need more time to solve than the estimation [Type] Enhancement Type of Issues
Projects
eShopOnlineApi
Status: ✅ Done
Milestone
[Stage01] Foundation (2 Sprints)
1 participant
@LyQuocCuong