mpv: fix error on launch by removing directories inside mpv's scripts directory #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 13, 2021 01:34
gogolnr1
pushed a commit
to gogolnr1/voidrice
that referenced
this pull request
Jun 28, 2023
… directory (LukeSmithxyz#1004) * remove dirs from mpv scripts dir * remove submodule dir from mpv scripts dir * add script_modules directory outside scripts direcoty * load modules/plugins from script_modules, outside mpv's script-files-only directory * rename variable
xorllc
pushed a commit
to xorllc/voidrice
that referenced
this pull request
Jun 9, 2024
… directory (LukeSmithxyz#1004) * remove dirs from mpv scripts dir * remove submodule dir from mpv scripts dir * add script_modules directory outside scripts direcoty * load modules/plugins from script_modules, outside mpv's script-files-only directory * rename variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes LukeSmithxyz/LARBS#326 and wis/mpvSockets#5
The error message is cryptic but I figured out it is caused by mpv trying to read and parse everything in the scripts directory as script files and failing to do so for the mpvSockets directory inside it.