Hack to respect safe areas #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like HasSystemPadding is now ignored and SystemPadding is always used. |
|
For the time being yes, this will be eventually reverted to be fixed however |
|
I never actually used HasSystemPadding property before, so I didn't think of adding it. Simply adding an if condition bfore applying the padding can make it work. I'll add a PR |
|
I am really sorry @LuckyDucko I made a mistake and merged the changes instead of creating a PR :| |
|
@AswinPG thats all good, no worries ahaha, i am the only one able to release a nuget. Give me a litte time to see whats changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LayoutChildren method does not work. This is a little hack to make the popup render inside safe area