You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are literally thousands of lines of output from pytest informing us about warnings.
tests/checkpointing/test_model_checkpoint.py::test_model_checkpoint_score_and_ckpt_val_check_interval[0.42-False-False]
/__w/pytorch-lightning/pytorch-lightning/pytorch_lightning/callbacks/model_checkpoint.py:622: UserWarning: Checkpoint directory /tmp/pytest-of-root/pytest-0/test_model_checkpoint_score_an8 exists and is not empty.
rank_zero_warn(f"Checkpoint directory {dirpath} exists and is not empty.")
It's simply not practical.
This PR disables this nonsense of endless scrolling.
The statistic of how many warnings there are in total is still visible like so: ==== 44 passed, 7 skipped, 217 warnings in 5.33s ====
Before submitting
Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified
There are literally thousands of lines of output from pytest informing us about warnings.
how much of the warnings would you estimate is due to overzealous warnings by the framework vs tests having real issues?
if we turn off warnings like this, would users turn off warnings too?
@ananthsub I would say the majority is definitely from the framework. The majority of warnings are "friendly" messages for users who haven't fully configured and tuned the settings. But in our tests, messages like these do not matter. For example, since we use BoringModel in practically every test, it will always raise this warning:
The dataloader, train_dataloader, does not have many workers which may be a bottleneck. Consider increasing the value of the num_workers argument`
ciContinuous IntegrationreadyPRs ready to be merged
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
awaelchli
changed the title
What does this PR do?
There are literally thousands of lines of output from pytest informing us about warnings.
It's simply not practical.
This PR disables this nonsense of endless scrolling.
The statistic of how many warnings there are in total is still visible like so:
==== 44 passed, 7 skipped, 217 warnings in 5.33s ====Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃