-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build XLA with py3.6 #2863
Merged
Merged
build XLA with py3.6 #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2863 +/- ##
======================================
Coverage 90% 90%
======================================
Files 81 81
Lines 7620 7620
======================================
Hits 6854 6854
Misses 766 766 |
@zcain117 trying to install python 3.6 on Debian 10...
|
9a7eef8
to
ca223d9
Compare
This pull request is now in conflict... :( |
there will be close follow-up to use this new docker image |
ameliatqy
pushed a commit
to ameliatqy/pytorch-lightning
that referenced
this pull request
Aug 17, 2020
* build py3.6 * info * conda * update * version * version * builds * builds * builds * builds * builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add support for building XLA also for python 3.6 with conda
fix other images...
there will be close follow-up to use this new docker image
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃