Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build XLA with py3.6 #2863

Merged
merged 11 commits into from
Aug 15, 2020
Merged

build XLA with py3.6 #2863

merged 11 commits into from
Aug 15, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 7, 2020

What does this PR do?

add support for building XLA also for python 3.6 with conda
fix other images...
there will be close follow-up to use this new docker image

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci Continuous Integration label Aug 7, 2020
@mergify mergify bot requested a review from a team August 7, 2020 14:26
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #2863 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2863   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files          81      81           
  Lines        7620    7620           
======================================
  Hits         6854    6854           
  Misses        766     766           

@Borda
Copy link
Member Author

Borda commented Aug 7, 2020

@zcain117 trying to install python 3.6 on Debian 10...

gpg: keybox '/tmp/tmpro5jzkzd/pubring.gpg' created
gpg: /tmp/tmpro5jzkzd/trustdb.gpg: trustdb created
gpg: key BA6932366A755776: public key "Launchpad PPA for deadsnakes" imported
gpg: Total number processed: 1
gpg:               imported: 1
Warning: apt-key output should not be parsed (stdout is not a terminal)
gpg: no valid OpenPGP data found.

@awaelchli awaelchli added this to the 1.0.0 milestone Aug 8, 2020
@Borda Borda force-pushed the dockers/xla branch 2 times, most recently from 9a7eef8 to ca223d9 Compare August 15, 2020 01:17
@Borda Borda marked this pull request as ready for review August 15, 2020 01:18
@Borda Borda changed the title build XLA with py3.6 [wip] build XLA with py3.6 Aug 15, 2020
@Borda Borda added the priority: 0 High priority task label Aug 15, 2020
@Borda Borda modified the milestones: 1.0.0, 0.9.0 Aug 15, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2020

This pull request is now in conflict... :(

@Borda
Copy link
Member Author

Borda commented Aug 15, 2020

there will be close follow-up to use this new docker image

@williamFalcon williamFalcon merged commit 9f2b29a into master Aug 15, 2020
@Borda Borda deleted the dockers/xla branch August 15, 2020 19:58
ameliatqy pushed a commit to ameliatqy/pytorch-lightning that referenced this pull request Aug 17, 2020
* build py3.6

* info

* conda

* update

* version

* version

* builds

* builds

* builds

* builds

* builds
@Borda Borda modified the milestones: 0.9.0, 1.0.0 Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants