Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: building XLA base image #2494

Merged
merged 9 commits into from
Jul 6, 2020
Merged

Docker: building XLA base image #2494

merged 9 commits into from
Jul 6, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 3, 2020 •
edited
Loading

What does this PR do?

Fixes #2489

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added feature Is an improvement or enhancement ci Continuous Integration labels Jul 3, 2020
@Borda Borda requested a review from zcain117 July 3, 2020 23:34
@mergify mergify bot requested a review from a team July 3, 2020 23:35
@Borda Borda marked this pull request as ready for review July 3, 2020 23:49
@Borda Borda requested a review from justusschock July 4, 2020 00:11
Borda
Borda commented Jul 4, 2020
View reviewed changes
dockers/tpu-base/Dockerfile Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2020

This pull request is now in conflict... :(

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2020

This pull request is now in conflict... :(

@Borda Borda force-pushed the docker/tpu-base branch from d1da140 to 90a6c83 Compare July 4, 2020 17:03
@codecov
Copy link

codecov bot commented Jul 4, 2020 •
edited
Loading

Codecov Report

Merging #2494 into master will increase coverage by 2%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #2494    +/-   ##
=======================================
+ Coverage      88%     90%    +2%     
=======================================
  Files          69      69            
  Lines        5609    5609            
=======================================
+ Hits         4944    5059   +115     
+ Misses        665     550   -115

@Borda
Copy link
Member Author

Borda commented Jul 4, 2020

@williamFalcon can we merge this one
cc: @PyTorchLightning/core-contributors @zcain117

@mergify mergify bot requested a review from a team July 6, 2020 15:42
@Borda Borda requested a review from zcain117 July 6, 2020 17:20
@Borda Borda added the ready PRs ready to be merged label Jul 6, 2020
@williamFalcon williamFalcon merged commit 977df6e into master Jul 6, 2020
@Borda Borda deleted the docker/tpu-base branch July 6, 2020 18:27
@Borda Borda mentioned this pull request Jul 7, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@jeremyjordan jeremyjordan Awaiting requested review from jeremyjordan

@luiscape luiscape Awaiting requested review from luiscape

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@zcain117 zcain117 Awaiting requested review from zcain117

Assignees
No one assigned
Labels
ci Continuous Integration feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create base TPU image
3 participants
@Borda @zcain117 @williamFalcon