New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure optimizer typing fix follow-up #20486

Merged

lantiga merged 1 commit into master from luca/configure-optimizer-return-typing-fix

Dec 10, 2024

Collaborator

lantiga commented Dec 10, 2024 •

edited by github-actions bot

Loading

What does this PR do?

Follow-up to #20471

adopts Type (vs Dict) as a suffix for TypedDict
adds classes to nitpick_ignore in autodoc config

📚 Documentation preview 📚: https://pytorch-lightning--20486.org.readthedocs.build/en/20486/


          Configure optimizer typing fix follow-up

465210a

lantiga requested review from Borda, tchaton, justusschock and ethanwharris as code owners

December 10, 2024 09:30

github-actions bot added docs pl labels

Contributor

github-actions bot commented Dec 10, 2024 •

edited

Loading

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-14, lightning, 3.9, 2.1, oldest)	success	✅
pl-cpu (macOS-14, lightning, 3.10, 2.1)	success	✅
pl-cpu (macOS-14, lightning, 3.11, 2.2.2)	success	✅
pl-cpu (macOS-14, lightning, 3.11, 2.3)	success	✅
pl-cpu (macOS-14, lightning, 3.12, 2.4.1)	success	✅
pl-cpu (macOS-14, lightning, 3.12, 2.5.1)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.3)	success	✅
pl-cpu (ubuntu-22.04, lightning, 3.12, 2.4.1)	success	✅
pl-cpu (ubuntu-22.04, lightning, 3.12, 2.5.1)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 2.1, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.1)	success	✅
pl-cpu (windows-2022, lightning, 3.11, 2.2.2)	success	✅
pl-cpu (windows-2022, lightning, 3.11, 2.3)	success	✅
pl-cpu (windows-2022, lightning, 3.12, 2.4.1)	success	✅
pl-cpu (windows-2022, lightning, 3.12, 2.5.1)	success	✅
pl-cpu (macOS-14, pytorch, 3.9, 2.1)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 2.1)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 2.1)	success	✅
pl-cpu (macOS-14, pytorch, 3.12, 2.5.1)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.12, 2.5.1)	success	✅
pl-cpu (windows-2022, pytorch, 3.12, 2.5.1)	success	✅

These checks are required after the changes to src/lightning/pytorch/utilities/types.py.

🔴 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs) (testing Lightning \| latest)	failure	❌
pytorch-lightning (GPUs) (testing PyTorch \| latest)	success	✅

These checks are required after the changes to src/lightning/pytorch/utilities/types.py.

🔴 pytorch_lightning: Benchmarks

Check ID	Status
lightning.Benchmarks	failure	❌

These checks are required after the changes to src/lightning/pytorch/utilities/types.py.

🟢 pytorch_lightning: Docs

Check ID	Status
docs-make (pytorch, doctest)	success	✅
docs-make (pytorch, html)	success	✅

These checks are required after the changes to src/lightning/pytorch/utilities/types.py, docs/source-pytorch/conf.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/pytorch/utilities/types.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, fabric, 3.9)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.11)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.9)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.11)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.9)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.11)	success	✅
install-pkg (ubuntu-22.04, notset, 3.9)	success	✅
install-pkg (ubuntu-22.04, notset, 3.11)	success	✅
install-pkg (macOS-14, fabric, 3.9)	success	✅
install-pkg (macOS-14, fabric, 3.11)	success	✅
install-pkg (macOS-14, pytorch, 3.9)	success	✅
install-pkg (macOS-14, pytorch, 3.11)	success	✅
install-pkg (macOS-14, lightning, 3.9)	success	✅
install-pkg (macOS-14, lightning, 3.11)	success	✅
install-pkg (macOS-14, notset, 3.9)	success	✅
install-pkg (macOS-14, notset, 3.11)	success	✅
install-pkg (windows-2022, fabric, 3.9)	success	✅
install-pkg (windows-2022, fabric, 3.11)	success	✅
install-pkg (windows-2022, pytorch, 3.9)	success	✅
install-pkg (windows-2022, pytorch, 3.11)	success	✅
install-pkg (windows-2022, lightning, 3.9)	success	✅
install-pkg (windows-2022, lightning, 3.11)	success	✅
install-pkg (windows-2022, notset, 3.9)	success	✅
install-pkg (windows-2022, notset, 3.11)	success	✅

These checks are required after the changes to src/lightning/pytorch/utilities/types.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

lantiga merged commit ca59e4e into master

68 of 75 checks passed

lantiga deleted the luca/configure-optimizer-return-typing-fix branch

December 10, 2024 09:46

codecov bot commented Dec 10, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (64d0d02) to head (465210a).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (64d0d02) and HEAD (465210a). Click for more details.

HEAD has 99 uploads less than BASE

Flag BASE (64d0d02) HEAD (465210a)

cpu 48 24

lightning 36 18

pytest 25 0

python3.9 12 6

lightning_fabric 7 0

python3.10 6 3

python3.11 12 6

python3.12 18 9

gpu 1 0

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #20486     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         267      264      -3     
  Lines       23287    23232     -55     
=========================================
- Hits        20169    18279   -1890     
- Misses       3118     4953   +1835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Borda Awaiting requested review from Borda Borda is a code owner

tchaton Awaiting requested review from tchaton tchaton is a code owner

justusschock Awaiting requested review from justusschock justusschock is a code owner

ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Labels

docs pl