Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TPU] XLAFSDP checkpointing fixes #18424

Merged
merged 14 commits into from
Aug 31, 2023
Merged

[TPU] XLAFSDP checkpointing fixes #18424

merged 14 commits into from
Aug 31, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Aug 29, 2023

@carmocca carmocca self-assigned this Aug 29, 2023
@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Aug 29, 2023
@carmocca carmocca added strategy: fsdp Fully Sharded Data Parallel strategy: xla and removed fabric lightning.fabric.Fabric strategy: fsdp Fully Sharded Data Parallel labels Aug 29, 2023
@carmocca carmocca added this to the 2.1 milestone Aug 29, 2023
@carmocca carmocca added bug Something isn't working checkpointing Related to checkpointing fabric lightning.fabric.Fabric labels Aug 29, 2023
@carmocca carmocca changed the title XLAFSDP checkpointing fixes [TPU] XLAFSDP checkpointing fixes Aug 29, 2023
@carmocca carmocca marked this pull request as ready for review August 29, 2023 19:26
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.11) success
pl-cpu (macOS-11, lightning, 3.9, 1.12) success
pl-cpu (macOS-11, lightning, 3.10, 1.13) success
pl-cpu (macOS-11, lightning, 3.10, 2.0) success
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11) success
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success
pl-cpu (windows-2022, lightning, 3.8, 1.11) success
pl-cpu (windows-2022, lightning, 3.9, 1.12) success
pl-cpu (windows-2022, lightning, 3.10, 1.13) success
pl-cpu (windows-2022, lightning, 3.10, 2.0) success
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success
pl-cpu (macOS-12, pytorch, 3.11, 2.0) success
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0) success
pl-cpu (windows-2022, pytorch, 3.11, 2.0) success

These checks are required after the changes to src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/cloud_io.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
[pytorch-lightning (GPUs) (testing Lightning latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=172279&view=logs&jobId=47e66f3c-897a-5428-da11-bf5c7745762e) success
[pytorch-lightning (GPUs) (testing PyTorch latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=172279&view=logs&jobId=3f274fac-2e11-54ca-487e-194c91f3ae9f) success

These checks are required after the changes to src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/cloud_io.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success

These checks are required after the changes to src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/cloud_io.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/cloud_io.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11) success
fabric-cpu (macOS-11, lightning, 3.9, 1.12) success
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success
fabric-cpu (macOS-11, lightning, 3.10, 2.0) success
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11) success
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success
fabric-cpu (windows-2022, lightning, 3.8, 1.11) success
fabric-cpu (windows-2022, lightning, 3.9, 1.12) success
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success
fabric-cpu (windows-2022, lightning, 3.10, 2.0) success
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success
fabric-cpu (macOS-12, fabric, 3.11, 2.0) success
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0) success
fabric-cpu (windows-2022, fabric, 3.11, 2.0) success

These checks are required after the changes to src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/cloud_io.py, tests/tests_fabric/strategies/test_xla_fsdp_integration.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
[lightning-fabric (GPUs) (testing Fabric latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=172281&view=logs&jobId=3f274fac-2e11-54ca-487e-194c91f3ae9f) success
[lightning-fabric (GPUs) (testing Lightning latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=172281&view=logs&jobId=b2def368-7fa8-5edf-f15e-38e7ac88d76c) success

These checks are required after the changes to src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/cloud_io.py, tests/tests_fabric/strategies/test_xla_fsdp_integration.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/cloud_io.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success
install-pkg (ubuntu-22.04, app, 3.11) success
install-pkg (ubuntu-22.04, fabric, 3.8) success
install-pkg (ubuntu-22.04, fabric, 3.11) success
install-pkg (ubuntu-22.04, pytorch, 3.8) success
install-pkg (ubuntu-22.04, pytorch, 3.11) success
install-pkg (ubuntu-22.04, lightning, 3.8) success
install-pkg (ubuntu-22.04, lightning, 3.11) success
install-pkg (ubuntu-22.04, notset, 3.8) success
install-pkg (ubuntu-22.04, notset, 3.11) success
install-pkg (macOS-12, app, 3.8) success
install-pkg (macOS-12, app, 3.11) success
install-pkg (macOS-12, fabric, 3.8) success
install-pkg (macOS-12, fabric, 3.11) success
install-pkg (macOS-12, pytorch, 3.8) success
install-pkg (macOS-12, pytorch, 3.11) success
install-pkg (macOS-12, lightning, 3.8) success
install-pkg (macOS-12, lightning, 3.11) success
install-pkg (macOS-12, notset, 3.8) success
install-pkg (macOS-12, notset, 3.11) success
install-pkg (windows-2022, app, 3.8) success
install-pkg (windows-2022, app, 3.11) success
install-pkg (windows-2022, fabric, 3.8) success
install-pkg (windows-2022, fabric, 3.11) success
install-pkg (windows-2022, pytorch, 3.8) success
install-pkg (windows-2022, pytorch, 3.11) success
install-pkg (windows-2022, lightning, 3.8) success
install-pkg (windows-2022, lightning, 3.11) success
install-pkg (windows-2022, notset, 3.8) success
install-pkg (windows-2022, notset, 3.11) success

These checks are required after the changes to src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/cloud_io.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@carmocca carmocca force-pushed the carmocca/xlafsdp-ckpt-fixes branch from 0b9900d to 284aefe Compare August 29, 2023 20:44
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #18424 (cf1d402) into master (e086c15) will decrease coverage by 9%.
Report is 1 commits behind head on master.
The diff coverage is 21%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #18424     +/-   ##
=========================================
- Coverage      63%      55%     -9%     
=========================================
  Files         427      422      -5     
  Lines       33254    33172     -82     
=========================================
- Hits        21072    18111   -2961     
- Misses      12182    15061   +2879     

@carmocca carmocca requested a review from awaelchli August 30, 2023 16:29
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@mergify mergify bot added the ready PRs ready to be merged label Aug 31, 2023
@carmocca carmocca merged commit 729e833 into master Aug 31, 2023
@carmocca carmocca deleted the carmocca/xlafsdp-ckpt-fixes branch August 31, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working checkpointing Related to checkpointing fabric lightning.fabric.Fabric ready PRs ready to be merged strategy: xla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants