-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TPU] XLAFSDP checkpointing fixes #18424
Merged
Merged
+60
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b9900d
to
284aefe
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18424 +/- ##
=========================================
- Coverage 63% 55% -9%
=========================================
Files 427 422 -5
Lines 33254 33172 -82
=========================================
- Hits 21072 18111 -2961
- Misses 12182 15061 +2879 |
awaelchli
reviewed
Aug 30, 2023
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
carmocca
commented
Aug 30, 2023
awaelchli
approved these changes
Aug 30, 2023
Borda
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
checkpointing
Related to checkpointing
fabric
lightning.fabric.Fabric
ready
PRs ready to be merged
strategy: xla
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Validated on Lit-GPT: Lightning-AI/litgpt#435
cc @Borda @awaelchli @carmocca @justusschock @JackCaoG @steventk-g @Liyang90 @gkroiz