Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import error when running doctests for RL examples #12010

Merged
merged 3 commits into from
Feb 19, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 19, 2022

What does this PR do?

Unblocks CI on master. Pygame is not installed but required for running doctests in pl_examples/domain_examples/reinforce_learn_Qnet.py

Fixes #12009

Does your PR introduce any breaking changes? If yes, please list them.

I would never do that!

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @carmocca @akihironitta

@awaelchli awaelchli added this to the 1.6 milestone Feb 19, 2022
@awaelchli awaelchli added the ci Continuous Integration label Feb 19, 2022
@awaelchli awaelchli changed the title Fix import error when running doctests for RL examples [WIP] Fix import error when running doctests for RL examples Feb 19, 2022
@awaelchli awaelchli changed the title [WIP] Fix import error when running doctests for RL examples Fix import error when running doctests for RL examples Feb 19, 2022
requirements/examples.txt Outdated Show resolved Hide resolved
@carmocca carmocca removed the tests label Feb 19, 2022
awaelchli and others added 2 commits February 19, 2022 17:47
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@mergify mergify bot added the ready PRs ready to be merged label Feb 19, 2022
@carmocca carmocca merged commit 923b30d into master Feb 19, 2022
@carmocca carmocca deleted the ci/examples-req branch February 19, 2022 20:57
@carmocca carmocca modified the milestones: 1.6, 1.5.x Feb 19, 2022
justusschock pushed a commit that referenced this pull request Feb 21, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI jobs failing with No module named 'pygame'
5 participants