Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Trainer._device_type #11992

Merged
merged 7 commits into from
Feb 22, 2022
Merged

Remove Trainer._device_type #11992

merged 7 commits into from
Feb 22, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 18, 2022 •
edited by awaelchli
Loading

What does this PR do?

Part of #11449
Part of #10821
Closes #11326

Does your PR introduce any breaking changes? If yes, please list them.

Removes the protected _device_type.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7 @akihironitta

@carmocca carmocca added this to the 1.6 milestone Feb 18, 2022
@carmocca carmocca self-assigned this Feb 18, 2022
@ananthsub ananthsub mentioned this pull request Feb 18, 2022
Merged
11 tasks
Base automatically changed from refactor/remove_strategy_type to master February 21, 2022 13:39
@kaushikb11
Copy link
Contributor

We have a logging issue right now on master.

GPU available: False, used: False
TPU available: True, using: 8 TPU cores
IPU available: False, using: 0 IPUs
/usr/local/lib/python3.8/dist-packages/pytorch_lightning-1.6.0.dev0-py3.8.egg/pytorch_lightning/trainer/trainer.py:1737: UserWarning: TPU available but not used. Set the `tpu_cores` flag in your trainer `Trainer(tpu_cores=8)` or script `--tpu_cores=8`.

This PR should resolve it.

@carmocca carmocca marked this pull request as ready for review February 21, 2022 14:32
@mergify mergify bot added the ready PRs ready to be merged label Feb 21, 2022
@carmocca carmocca enabled auto-merge (squash) February 21, 2022 14:34
tchaton
tchaton approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@carmocca carmocca merged commit 4c4b9d5 into master Feb 22, 2022
@carmocca carmocca deleted the refactor/remove_device_type branch February 22, 2022 13:02
@four4fish four4fish mentioned this pull request Feb 23, 2022
Closed
@carmocca carmocca mentioned this pull request Feb 25, 2022
Closed
@DuYicong515 DuYicong515 mentioned this pull request Mar 26, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@four4fish four4fish four4fish approved these changes

@justusschock justusschock justusschock approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

Assignees

@carmocca carmocca

Labels
accelerator ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
8 participants
@carmocca @kaushikb11 @ananthsub @awaelchli @tchaton @justusschock @rohitgr7 @four4fish