Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore test after #11448 #11986

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Restore test after #11448 #11986

merged 1 commit into from
Feb 19, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 18, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #11448 (comment)

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @akihironitta

@carmocca carmocca added the tests label Feb 18, 2022
@carmocca carmocca added this to the 1.6 milestone Feb 18, 2022
@carmocca carmocca self-assigned this Feb 18, 2022
@kaushikb11 kaushikb11 enabled auto-merge (squash) February 18, 2022 12:37
@mergify mergify bot added the ready PRs ready to be merged label Feb 18, 2022
@four4fish
Copy link
Contributor

Thank you for fixing this. I completely misunderstood in 11448, I thought you were just showing me this is how to set the env_arg to make the device=2, didn't realize this is desired tests.
Actually do you think we can keep both?

@four4fish
Copy link
Contributor

nvm, it's more confusing to keep both, this is good!

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #11986 (fc5211c) into master (cf64f34) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11986   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         204      204           
  Lines       17337    17337           
=======================================
  Hits        15869    15869           
  Misses       1468     1468

@kaushikb11 kaushikb11 merged commit 6bc0e1d into master Feb 19, 2022
@kaushikb11 kaushikb11 deleted the tests/fix branch February 19, 2022 21:39
justusschock pushed a commit that referenced this pull request Feb 21, 2022
@carmocca @justusschock
Restore test after #11448 (#11986)
4f491a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@four4fish four4fish four4fish approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees

@carmocca carmocca

Labels
ready PRs ready to be merged tests
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@carmocca @four4fish @ananthsub @awaelchli @kaushikb11