Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor signature for launcher #11967

Merged
merged 5 commits into from
Feb 21, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 17, 2022

What does this PR do?

Follow up to #11643
Addresses review comment by @carmocca

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7 @kaushikb11 @akihironitta

@awaelchli awaelchli added this to the 1.6 milestone Feb 17, 2022
@awaelchli awaelchli marked this pull request as ready for review February 17, 2022 21:52
@mergify mergify bot added the ready PRs ready to be merged label Feb 17, 2022
@awaelchli awaelchli enabled auto-merge (squash) February 18, 2022 22:53
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @awaelchli @carmocca for addressing this :)
sorry, I was OOO last week, and also afk, so couldn't address it there.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli disabled auto-merge February 21, 2022 20:11
@awaelchli awaelchli merged commit 57aae59 into master Feb 21, 2022
@awaelchli awaelchli deleted the refactor/launcher-trainer-argument branch February 21, 2022 20:11
@awaelchli awaelchli added strategy: ddp DistributedDataParallel and removed strategy: ddp spawn labels Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor strategy: ddp DistributedDataParallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants