Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix upload-artifact #11962

Merged
merged 2 commits into from
Feb 21, 2022
Merged

CI: fix upload-artifact #11962

merged 2 commits into from
Feb 21, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 17, 2022

What does this PR do?

While inspection it turned out that failing tests were not uploading reports
for example https://github.com/PyTorchLightning/pytorch-lightning/actions/runs/1857677830

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@Borda Borda added the ci Continuous Integration label Feb 17, 2022
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

.github/workflows/ci_test-slow.yml Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Feb 20, 2022
@mergify mergify bot requested a review from a team February 20, 2022 11:26
@carmocca carmocca added this to the 1.6 milestone Feb 21, 2022
@Borda Borda merged commit 9b0942d into master Feb 21, 2022
@Borda Borda deleted the ci/upload-artifact branch February 21, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants