Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing imports in converting.rst #11945

Merged
merged 3 commits into from
Feb 21, 2022

Conversation

rjkilpatrick
Copy link
Contributor

@rjkilpatrick rjkilpatrick commented Feb 16, 2022

What does this PR do?

Specifies imports to help remove any barriers to new users

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • s this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Reducing barriers to entry is always fun 🚀

Specifies imports to help remove any barriers to new users
@ananthsub ananthsub added the docs Documentation related label Feb 16, 2022
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could pls also use the checkboxes? it may simplify the review process... 🐰

@mergify mergify bot added the ready PRs ready to be merged label Feb 16, 2022
@rjkilpatrick rjkilpatrick changed the title Update converting.rst Fix missing imports in converting.rst Feb 18, 2022
@awaelchli awaelchli enabled auto-merge (squash) February 19, 2022 17:17
@awaelchli awaelchli modified the milestones: 1.6, 1.5.x Feb 19, 2022
@awaelchli awaelchli disabled auto-merge February 19, 2022 22:16
@awaelchli awaelchli enabled auto-merge (squash) February 19, 2022 22:16
@awaelchli awaelchli disabled auto-merge February 21, 2022 21:25
@awaelchli awaelchli merged commit b5c1358 into Lightning-AI:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants