Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests/plugins/*.py to use devices instead of gpus or ipus #11872

Merged
merged 5 commits into from
Feb 21, 2022
Merged

Update tests/plugins/*.py to use devices instead of gpus or ipus #11872

merged 5 commits into from
Feb 21, 2022

Conversation

mathemusician
Copy link
Contributor

@mathemusician mathemusician commented Feb 11, 2022 •
edited
Loading

What does this PR do?

Update test to deprecate num_processes, gpus, tpu_cores, and ipus from the Trainer constructor

Part of Pull 11040.

🌳 Trello Board Link

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@mathemusician mathemusician marked this pull request as ready for review February 17, 2022 21:14
@awaelchli awaelchli enabled auto-merge (squash) February 19, 2022 03:07
@mergify mergify bot added the ready PRs ready to be merged label Feb 19, 2022
@awaelchli awaelchli added this to the 1.6 milestone Feb 20, 2022
@mathemusician
Copy link
Contributor Author

The Milestone Check is taking a long time

@rohitgr7
Copy link
Contributor

The Milestone Check is taking a long time

it's blocking a few prs, we will be removing it from required to unblock them.

@awaelchli awaelchli disabled auto-merge February 21, 2022 21:57
@awaelchli awaelchli merged commit 9c067c2 into Lightning-AI:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@mathemusician @rohitgr7 @ananthsub @awaelchli @akihironitta