Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor early stopping test #11866

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Refactor early stopping test #11866

merged 2 commits into from
Feb 17, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 11, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Refactor a legacy early stopping test.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @akihironitta @carmocca @awaelchli @rohitgr7

@carmocca carmocca added this to the 1.6 milestone Feb 11, 2022
@carmocca carmocca self-assigned this Feb 11, 2022
@mergify mergify bot added the ready PRs ready to be merged label Feb 14, 2022
@carmocca carmocca mentioned this pull request Feb 14, 2022
Closed
8 tasks
@carmocca carmocca enabled auto-merge (squash) February 17, 2022 22:10
@carmocca carmocca merged commit a0ca8d0 into master Feb 17, 2022
@carmocca carmocca deleted the tests/refactor-es-test branch February 17, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@carmocca carmocca

Labels
callback: early stopping ready PRs ready to be merged tests
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
4 participants
@carmocca @ananthsub @awaelchli @rohitgr7