Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyTorch documentation updates #11739

Merged
merged 5 commits into from
Feb 21, 2022
Merged

PyTorch documentation updates #11739

merged 5 commits into from
Feb 21, 2022

Conversation

zredeaux65
Copy link
Contributor

@zredeaux65 zredeaux65 commented Feb 4, 2022 •
edited
Loading

Corrected typos and sentence structure.

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@zredeaux65
PyTorch documentation updates
0c6583c 
Corrected typos and sentence structure.
@mergify mergify bot added the has conflicts label Feb 4, 2022
ethanwharris
ethanwharris reviewed Feb 4, 2022
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Few comments 😃

docs/source/starter/introduction_guide.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/new-project.rst Outdated Show resolved Hide resolved
docs/source/starter/new-project.rst Outdated Show resolved Hide resolved
awaelchli
awaelchli approved these changes Feb 5, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

docs/source/starter/introduction_guide.rst Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Show resolved Hide resolved
docs/source/starter/new-project.rst Outdated Show resolved Hide resolved
@akihironitta akihironitta added the docs Documentation related label Feb 7, 2022
tchaton
tchaton approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow ! Really impressive work !

docs/source/starter/introduction_guide.rst Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Feb 9, 2022
@mergify mergify bot requested a review from a team February 9, 2022 12:22
rohitgr7
rohitgr7 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really amazing improvements 😃
thank you

docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
@carmocca carmocca added this to the 1.6 milestone Feb 10, 2022
@rohitgr7 @ethanwharris @tchaton
Apply suggestions from code review
0cd4fba 
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
@rohitgr7 rohitgr7 enabled auto-merge (squash) February 10, 2022 20:00
auto-merge was automatically disabled February 10, 2022 21:31

Head branch was pushed to by a user without write access

@awaelchli awaelchli enabled auto-merge (squash) February 11, 2022 05:54
@awaelchli awaelchli disabled auto-merge February 11, 2022 05:57
@awaelchli awaelchli self-requested a review February 11, 2022 06:29
@rohitgr7 rohitgr7 force-pushed the origin/doc/pytorch-lightning branch from ee1442a to 0cd4fba Compare February 11, 2022 11:45
@awaelchli awaelchli mentioned this pull request Feb 11, 2022
Closed
8 tasks
@rohitgr7 rohitgr7 enabled auto-merge (squash) February 14, 2022 10:00
@mergify mergify bot removed the has conflicts label Feb 21, 2022
@rohitgr7 rohitgr7 merged commit 70f9c6f into Lightning-AI:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanwharris ethanwharris ethanwharris left review comments

@s-rog s-rog s-rog approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@tchaton tchaton tchaton approved these changes

@Borda Borda Borda approved these changes

@ananthsub ananthsub ananthsub approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@awaelchli awaelchli Awaiting requested review from awaelchli

Assignees
No one assigned
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.