Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PT to PL conversion doc #11397

Merged
merged 6 commits into from
Feb 21, 2022
Merged

Update PT to PL conversion doc #11397

merged 6 commits into from
Feb 21, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jan 10, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Part of docs revamp #7666

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7

@rohitgr7 rohitgr7 added the docs Documentation related label Jan 10, 2022
@rohitgr7 rohitgr7 added this to the 1.6 milestone Jan 10, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review January 10, 2022 18:12
Borda
Borda reviewed Jan 10, 2022
View reviewed changes
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Show resolved Hide resolved
@rohitgr7 rohitgr7 requested a review from Borda January 10, 2022 20:37
tchaton
tchaton reviewed Jan 11, 2022
View reviewed changes
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Show resolved Hide resolved
@rohitgr7 rohitgr7 requested a review from tchaton January 12, 2022 14:09
tchaton
tchaton approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work !

docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Show resolved Hide resolved
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
@rohitgr7 @tchaton
Apply suggestions from code review
400af02 
Co-authored-by: thomas chaton <thomas@grid.ai>
@rohitgr7 rohitgr7 enabled auto-merge (squash) February 9, 2022 11:15
@mergify mergify bot added the ready PRs ready to be merged label Feb 10, 2022
ethanwharris
ethanwharris approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some small suggestions

docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
docs/source/starter/converting.rst Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 modified the milestones: 1.6, 1.5.x Feb 21, 2022
@rohitgr7 rohitgr7 modified the milestones: 1.5.x, 1.6 Feb 21, 2022
@rohitgr7 rohitgr7 disabled auto-merge February 21, 2022 19:46
@rohitgr7 rohitgr7 merged commit f811284 into master Feb 21, 2022
@rohitgr7 rohitgr7 deleted the docs/pt_conv_pl branch February 21, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton approved these changes

@carmocca carmocca carmocca approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@edenlightning edenlightning Awaiting requested review from edenlightning

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@akihironitta akihironitta Awaiting requested review from akihironitta

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@rohitgr7 @Borda @ethanwharris @carmocca @tchaton