Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare v1.5.0rc1 #10068

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Prepare v1.5.0rc1 #10068

merged 1 commit into from
Oct 22, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Prepare v1.5.0rc1

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

tchaton
tchaton approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@mergify mergify bot added the ready PRs ready to be merged label Oct 22, 2021
@mergify mergify bot requested a review from a team October 22, 2021 06:58
@Borda
Copy link
Member

Borda commented Oct 22, 2021

Did anyone the sanity check of the changelog? meaning, manually check if all major changes (commits) since the last v1.4 are included in the changelog? @kaushikb11

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #10068 (fae674f) into master (8482c28) will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #10068   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         182      182           
  Lines       16111    16111           
=======================================
  Hits        14894    14894           
  Misses       1217     1217

@awaelchli awaelchli enabled auto-merge (squash) October 22, 2021 08:47
@tchaton
Copy link
Contributor

tchaton commented Oct 22, 2021

@Borda

@Borda
Copy link
Member

Borda commented Oct 22, 2021 •
edited
Loading

@tchaton #10068 (comment)

@kaushikb11 kaushikb11 disabled auto-merge October 22, 2021 13:35
@lexierule lexierule merged commit c9bc10c into master Oct 22, 2021
@lexierule lexierule deleted the v1.5.0rc1 branch October 22, 2021 15:00
awaelchli added a commit that referenced this pull request Oct 22, 2021
@awaelchli
Revert "Prepare v1.5.0rc1 (#10068)"
b31e0ec 
This reverts commit c9bc10c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-rog s-rog s-rog approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
ready PRs ready to be merged release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kaushikb11 @Borda @tchaton @awaelchli @SkafteNicki @rohitgr7 @s-rog @lexierule