Fix startup errors, add unit test for scheduled task errors (fixes #5209) #5269
+298
−363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
force-pushed
the
no-startup-errors
branch
from
1512650 to
323b154
Compare
Nutomic
changed the title
Nutomic
changed the title
Nutomic
commented
Dec 19, 2024
| @@ -111,49 +141,44 @@ pub async fn setup(context: Data<LemmyContext>) -> LemmyResult<()> { | |||
| } | |||
There was a problem hiding this comment.
Changed this file so that all the individual tasks return result, and only the top-level handler logs them. That way we can use a simple unit test to ensure that no errors are thrown.
Nutomic
force-pushed
the
no-startup-errors
branch
from
ada058a to
53e6c3d
Compare
Nutomic
force-pushed
the
no-startup-errors
branch
from
2199c80 to
8e5a014
Compare
Nutomic
requested review from
dessalines,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
dessalines
approved these changes
Dec 19, 2024
dullbananas
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Because you changes utils.sql and #4673 has not been merged yet, you must add a migration that just runs SELECT;, as explained in comments in schema_setup.rs
|
@dullbananas Done. |
dullbananas
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.