Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix entrypoint in Dockerfile #4202

Merged
merged 5 commits into from
Nov 26, 2023
Merged

Fix entrypoint in Dockerfile #4202

merged 5 commits into from
Nov 26, 2023

Conversation

kroese
Copy link
Contributor

@kroese kroese commented Nov 25, 2023

This pull request contains two changes:

  • If fixes the entrypoint for amd64 builds
  • It removes the need for an intermediate container for arm64 builds

@kroese kroese mentioned this pull request Nov 25, 2023
Merged
@dessalines
Copy link
Member

Thxs, I'll start a build for this in a minute.

@raskyld
Copy link
Contributor

raskyld commented Nov 25, 2023

Since we no longer have the intermediate image, you can remove the exception added in the .dockerignore at the root of the repository!

GJ for pointing out buildkit can run emulation or native on a per-stage basis :) 👏

@raskyld
Copy link
Contributor

raskyld commented Nov 25, 2023 •
edited
Loading

Also, shouldn't we change the woodpecker CI config file?

This stage can be removed:

lemmy/.woodpecker.yml

Line 230 in 8a05c8f

publish_builder_arm64:

@dessalines
Copy link
Member

Another started.

dessalines
dessalines approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag passed, thx!

@SleeplessOne1917 SleeplessOne1917 merged commit fc07ba2 into LemmyNet:main Nov 26, 2023
@ticoombs ticoombs mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines approved these changes

@Nutomic Nutomic Awaiting requested review from Nutomic Nutomic is a code owner

@phiresky phiresky Awaiting requested review from phiresky phiresky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kroese @dessalines @raskyld @SleeplessOne1917