Migrate comment inReplyTo field to single value (ref #1454) #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you'd like to do it this way, that's up to you, but don't be afraid to make breaking changes in the federation code. Anytime we do that, we just have to make sure its a minor or major release. |
|
I am going to do some other breaking changes where migrations wont be possible (or too complicated), but I dont want to break something as basic as comment federation. That would only lead to more centralization around lemmy.ml. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how we can do protocol migrations now with the new way of sending and receiving apub objects. I think its very elegant.
Tested by inspecting the json, and by temporarily changing the code to send the new variant (works fine).