User / community blocking. Fixes #426 #1604
Conversation
dessalines
force-pushed
the
user_community_blocking
branch
2 times, most recently
from
208f2f9 to
4a5787b
Compare
dessalines
changed the title
dessalines
changed the title
crates/api/src/community.rs
Outdated
| } | ||
| } | ||
|
|
||
| // TODO does any federated stuff need to be done here? |
There was a problem hiding this comment.
Not sure if we want to federate any of this, I'm guessing no.
There was a problem hiding this comment.
We could send an unsubscribe to the community. That way, if the local user was the only follower of a remote community, it wont try to deliver its posts to the instance (where they would be ignored).
There was a problem hiding this comment.
Hrm... for now lets let unsubscribe be its own activity.
There was a problem hiding this comment.
I mean sending an Undo/Follow to the community, i'm not proposing any changes to the apub code.
There was a problem hiding this comment.
Okay, I just added unfollowing that community and sending the abup undofollowcommunity
migrations/2021-08-04-223559_create_user_community_block/up.sql
Outdated
Show resolved
Hide resolved
|
After a quick look over it, looks fine except for some minor things. In general I would prefer if you try to put the comments you added here directly into the code instead. If someone in the future wants to understand what it does, they will read the code and not an old PR. |
dessalines
force-pushed
the
user_community_blocking
branch
from
724624a to
5bcd39e
Compare
dessalines
force-pushed
the
user_community_blocking
branch
from
9e5efc0 to
8b0a8ba
Compare
dessalines
force-pushed
the
user_community_blocking
branch
from
8b0a8ba to
7e45d9a
Compare
There are several breaking API changes, which are more easily viewed here: LemmyNet/lemmy-js-client#22
I'll review this now to go over the main changes.