Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed screenshot paths #1355

Closed
wants to merge 1 commit into from
Closed

fixed screenshot paths #1355

wants to merge 1 commit into from

Conversation

danielbartsch
Copy link

They aren't showing, as the links point to nothing. This makes them use relative links, which work.

Before this PR:
grafik

@dessalines
Copy link
Member

Ah, thanks for catching. This doesn't work tho because the docs folder is a submodule: https://github.com/LemmyNet/lemmy/blob/main/docs/img/chat_screen.png

You need to link to the file in that lemmy-docs repo.

@Nutomic
Copy link
Member

Nutomic commented Jan 22, 2021

Sorry I forgot about this PR and fixed the problem myself. Anyway, thanks for the contribution :)

LemmyNet/lemmy-docs#8

@Nutomic Nutomic closed this Jan 22, 2021
@danielbartsch
Copy link
Author

sorry but it still doesn't work, check https://github.com/LemmyNet/lemmy/blob/main/README.md

@dessalines dessalines reopened this Jan 27, 2021
dessalines added a commit that referenced this pull request Feb 6, 2021
@dessalines dessalines closed this Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants