Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create img badges directly in jekyll #8718

Merged
merged 3 commits into from
Dec 18, 2022
Merged

Create img badges directly in jekyll #8718

merged 3 commits into from
Dec 18, 2022

Conversation

Falke-Design
Copy link
Member

@Falke-Design Falke-Design commented Dec 17, 2022 •
edited
Loading

Attempt to create the badges directly in Jekyll.

Closes #8716, #8717

grafik

@Falke-Design Falke-Design mentioned this pull request Dec 17, 2022
Closed
@Falke-Design Falke-Design marked this pull request as ready for review December 18, 2022 10:20
IvanSanchez
IvanSanchez approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@IvanSanchez IvanSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot understand much Ruby (but the "piping data to a jekyll helper" bit looks good) , and my local installation of Jekyll is a bit of a mess, so I'm just gonna assume you've tested it.

@Falke-Design Falke-Design merged commit 6877150 into Leaflet:main Dec 18, 2022
@mourner
Copy link
Member

mourner commented Dec 18, 2022

@Falke-Design should probably be reverted — it's not working. The plugins page looks like this now:

image

Falke-Design added a commit that referenced this pull request Dec 18, 2022
@Falke-Design
Revert "Create img badges directly in jekyll (#8718)"
53bab67 
This reverts commit 6877150.
@Falke-Design Falke-Design mentioned this pull request Dec 18, 2022
Merged
@Falke-Design
Copy link
Member Author

@mourner Done

@Falke-Design
Copy link
Member Author

@mourner @jonkoops it is not possible to use custom filters with github-pages ... Github overwrites the directory path of the custom plugin with a random string, so it is never possible to include custom plugins / filters.

grafik
jekyll/jekyll#5265 (comment)

@jonkoops
Copy link
Collaborator

@Falke-Design any chance the fix mentioned in jekyll/jekyll#5265 (comment) could also work for us here?

@Falke-Design
Copy link
Member Author

@jonkoops no doesn't work 😕

https://falke-design.github.io/Leaflet/plugins.html
https://github.com/Falke-Design/Leaflet/tree/docs/jekyll-badges
https://github.com/Falke-Design/Leaflet/blob/docs/jekyll-badges/docs/Gemfile

@jonkoops
Copy link
Collaborator

Ah that's a bummer indeed. It would be really nice if we could get it to work server-side.

@mourner
Copy link
Member

mourner commented Dec 22, 2022

@jonkoops in the meantime, maybe we could simulate the lazy loading by adding the badges when scrolling in view with IntersectionObserver?

@jonkoops
Copy link
Collaborator

I actually have a working version of the loading="lazy" functionality on my other machine. I'll see if I can pull it up once I have it up and running (moving countries atm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanSanchez IvanSanchez IvanSanchez approved these changes

@mourner mourner mourner approved these changes

@jonkoops jonkoops Awaiting requested review from jonkoops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize star / recency labels on the plugins page
4 participants
@Falke-Design @mourner @jonkoops @IvanSanchez