Vector Drift Test Pinch Zoom Fix #8644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Florian Bischof <design.falke@gmail.com>
misbahkhalilaz
approved these changes
Nov 16, 2022
Falke-Design
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Works perfectly, thank you!
#8794 fixes the zoomAnimation: false bug. An additional test will be added there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected test to be able to get SVG size and coords correctly. Also discovered that a bug is still present with the help of #8103 (comment).
When going through the debugger,
Draggable.disabled()was being called ifzoomAnimationisfalse. IfzoomAnimationistrue,Draggable.enabled()is called instead and is properly fixed.This test will be slow due to the fact of
zoomAnimationbeing enabled as the bug has not be fixed whenzoomAnimationisfalse.Fixes #8117.
Issue #7466 most likely will need to be reopened.