Remove Internet Explorer from browser detection #8559
Conversation
jonkoops
added
api
compatibility
|
@Falke-Design Yeah, I was thinking we could perhaps already create a draft release for 2.0 with all the breaking changes and migration guide. That way we don't have to retroactively compile it all. |
|
Sounds good. But let us only add for now the main things like breaking / API changes so that we don't forget them. And then before the release, I go over all the commits again and add everything else |
|
Exactly what I was thinking, I'll get on that after merging this in. |
| @@ -92,7 +92,7 @@ css: "#map { | |||
| fillOpacity: 0.7 | |||
| }); | |||
|
|
|||
| if (!L.Browser.ie && !L.Browser.opera && !L.Browser.edge) { | |||
| if (!L.Browser.opera && !L.Browser.edge) { | |||
There was a problem hiding this comment.
BTW, the other two switches here are suspicious. For edge, is this detecting the old IE-based Edge, not the Chromium one? And why would Opera not work here if it's also pretty much a flavour of Chrome now? Maybe we could get rid of both of these too.
There was a problem hiding this comment.
For edge, is this detecting the old IE-based Edge, not the Chromium one?
Yes, this only detects the old (non-Chromium) based Edge. The same goes for the detection of Opera. I'll be removing more browsers from this detection code that are no longer relevant to our support target.
I'm also thinking of replacing all checks for Chrome with 'Chromium-based' browsers, treating them all as the same thing. Since they share the same engine this should make the code a bit simpler.
Removes Internet Explorer from the browser detection code and removes all related code based on these checks. This removes the following APIs:
L.Browser.ieL.Browser.ielt9L.Browser.ie3d