Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dependabot config for Bundler dependencies #8516

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

jonkoops
Copy link
Collaborator

@jonkoops jonkoops commented Oct 3, 2022

Adds a Dependabot config to keep our Bundler dependencies up to date.

@jonkoops jonkoops added the workflow Anything related to Leaflet development process and tools label Oct 3, 2022
@jonkoops jonkoops self-assigned this Oct 3, 2022
.gitignore Show resolved Hide resolved
.gitignore Show resolved Hide resolved
docs/.ruby-version Outdated Show resolved Hide resolved
docs/Gemfile Show resolved Hide resolved
@jonkoops jonkoops force-pushed the dependabot-bundler branch 2 times, most recently from ef09e67 to 5a011eb Compare October 3, 2022 10:17
package.json Outdated Show resolved Hide resolved
docs/.ruby-version Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/Gemfile Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@jonkoops jonkoops force-pushed the dependabot-bundler branch from 5a011eb to 7111a5c Compare October 3, 2022 20:07
@jonkoops
Copy link
Collaborator Author

jonkoops commented Oct 3, 2022

@mourner @Falke-Design I've restored the NPM script and updated things so Ruby 3 should also work. Looks like the lockfile from my M1 Mac is causing issues, so I will regen it on another machine.

@jonkoops jonkoops requested a review from Falke-Design October 3, 2022 20:10
@jonkoops jonkoops force-pushed the dependabot-bundler branch from 7111a5c to 8e314a5 Compare October 4, 2022 08:36
@jonkoops
Copy link
Collaborator Author

jonkoops commented Oct 4, 2022

Nice, the CI is all green now ✔️

CONTRIBUTING.md Outdated Show resolved Hide resolved
@jonkoops jonkoops force-pushed the dependabot-bundler branch from 8e314a5 to ba87c4b Compare October 4, 2022 14:24
@jonkoops jonkoops requested a review from Falke-Design October 4, 2022 14:24
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but would still want a comment on this:

If you reverted to supporting both v2 and v3, should we drop the .ruby-version file as well then so that there's no specific Ruby version installation hassle when running docs locally?

@jonkoops
Copy link
Collaborator Author

jonkoops commented Oct 4, 2022

I think we should keep the .ruby-version file around as it seems to be a convention in the world of Ruby tooling.

For example the Github Action we use to set up Ruby works out of the box with it, and rbenv automatically switches to the correct version of Ruby when cding into a directory that has this file.

@jonkoops jonkoops merged commit 66c9b7e into main Oct 4, 2022
@jonkoops jonkoops deleted the dependabot-bundler branch October 4, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow Anything related to Leaflet development process and tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants